Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update libssl and openssl versions #3728

Merged
merged 2 commits into from
Nov 12, 2024
Merged

update libssl and openssl versions #3728

merged 2 commits into from
Nov 12, 2024

Conversation

brostk
Copy link
Contributor

@brostk brostk commented Nov 12, 2024

What was the problem?

Associated tickets or Slack threads:

  • #?

How does this fix it?1

How to test this PR

  • Step 1
  • Step 22

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

  2. To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline. ↩

@brostk brostk marked this pull request as ready for review November 12, 2024 16:56
@brostk brostk requested a review from a team as a code owner November 12, 2024 16:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

Test Results

136 tests  ±0   136 ✅ ±0   29s ⏱️ +3s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 5a67dd5. ± Comparison against base commit a01d4ed.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

JaCoCo Test Coverage

Overall Project 71.24% ❌

There is no coverage information present for the Files changed

gabezurita
gabezurita approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@gabezurita gabezurita left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! err, realizing we've got failing CI

@gabezurita gabezurita self-requested a review November 12, 2024 18:07
@gabezurita
Copy link
Collaborator

Are the failing CI checks of concern?
image

gabezurita
gabezurita approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@gabezurita gabezurita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brostk brostk merged commit 3e2d8e4 into develop Nov 12, 2024
16 checks passed
@brostk brostk deleted the brostk/docker-fix branch November 12, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabezurita gabezurita gabezurita approved these changes

@PaulKBaumann PaulKBaumann Awaiting requested review from PaulKBaumann PaulKBaumann is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@dfitchett dfitchett Awaiting requested review from dfitchett dfitchett is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brostk @gabezurita